Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added coverage metric in report #391

Merged
merged 10 commits into from
May 31, 2023
Merged

Added coverage metric in report #391

merged 10 commits into from
May 31, 2023

Conversation

therealryan
Copy link
Contributor

@therealryan therealryan commented May 25, 2023 •
edited
Loading

Resolves #233

Adding end-to-end testing for that functionality didn't appeal, so we did much more work to:

  1. Get the angular unit tests into shape - this involved mocking a bunch of constructor dependencies
  2. Added unit testing for the new behaviour
  3. Adding the maven config to run the unit tests on build

@sonarcloud
Copy link

sonarcloud bot commented May 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@therealryan therealryan merged commit 3927656 into main May 31, 2023
@therealryan therealryan deleted the coverage_metric branch May 31, 2023 08:43
@therealryan therealryan added the enhancement New feature or request label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Coverage metric in report
1 participant
@therealryan